Skip to content

fix(ServiceBus): Workaround health API timeout#1625

Merged
HofmeisterAn merged 2 commits intodevelopfrom
bugfix/fix-service-bus
Jan 17, 2026
Merged

fix(ServiceBus): Workaround health API timeout#1625
HofmeisterAn merged 2 commits intodevelopfrom
bugfix/fix-service-bus

Conversation

@HofmeisterAn
Copy link
Copy Markdown
Collaborator

@HofmeisterAn HofmeisterAn commented Jan 17, 2026 •
edited by coderabbitai Bot
Loading

What does this PR do?

-

Why is it important?

-

Related issues

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced Service Bus emulator startup health verification by adding log-based validation.
    • Simplified Event Hubs emulator initialization by removing legacy workarounds.

  • Chores

    • Removed unused global imports.

✏️ Tip: You can customize this high-level summary in your review settings.

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Jan 17, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 17, 2026 •
edited
Loading

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit dde205f
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/696b7a42e1d425000817b4df
😎 Deploy Preview https://deploy-preview-1625--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 17, 2026 •
edited
Loading

Walkthrough

The PR enhances Azure Emulator container wait strategies by replacing a custom workaround with a log-based readiness check before HTTP health verification. The workaround class is removed from EventHubs, and an unused global using statement is also cleaned up.

Changes

Cohort / File(s) Summary
Emulator Wait Strategy Refinement
src/Testcontainers.ServiceBus/ServiceBusBuilder.cs, src/Testcontainers.EventHubs/EventHubsBuilder.cs		 Modified Init method wait strategies: prepended UntilMessageIsLogged("Emulator Service is Successfully Up!") before HTTP health checks with referencing comments. Removed custom WorkaroundGhIssue69 class from EventHubs, simplifying the wait strategy chain.
Dependency Cleanup
src/Testcontainers.EventHubs/Usings.cs		 Removed unused global using directive for System.Threading.Tasks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #1624: Modifies EventHubsBuilder wait strategy and directly relates to the WorkaroundGhIssue69 workaround being replaced in this PR.

Poem

🐰 With whiskers twitched and nose in the air,
We hopped through the wait strategies with care,
Removed the old workaround's twisted knot,
Log checks first, then HTTP on the dot!
Clean code hops faster, hip-hop hooray! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is largely incomplete. While it includes the template structure with related issues (#1624), the mandatory sections 'What does this PR do?' and 'Why is it important?' contain only placeholder dashes (-) with no actual details. Complete the mandatory sections by explaining what changes were made (patterns, design), why they are important (rationale/motivation), and how to test the PR. These details are essential for code review.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(ServiceBus): Workaround health API timeout' is specific and directly related to the main change - addressing a health API timeout issue in ServiceBus by adding a log message check before the HTTP health check.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HofmeisterAn HofmeisterAn merged commit 4f41444 into develop Jan 17, 2026
18 checks passed
@HofmeisterAn HofmeisterAn deleted the bugfix/fix-service-bus branch January 17, 2026 12:27
@coderabbitai coderabbitai Bot mentioned this pull request Jan 19, 2026
Closed
This was referenced Feb 7, 2026
Closed
Merged
This was referenced Feb 23, 2026
Closed
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HofmeisterAn